lkml.org 
[lkml]   [2020]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v6 1/2] ASoC: google: dt-bindings: modify machine bindings for two MICs case
Hi, Rob

I follow your suggests that adding (maxItems: 1) for dmic-gpis property,
and keep one example of adding dmic-gpios property in it

Could you please kindly review it ?

Thank you so much
Ajye

On Fri, Nov 6, 2020 at 2:14 PM Ajye Huang <ajye.huang@gmail.com> wrote:
>
> Add a property "dmic-gpios" for switching between two MICs.
>
> Signed-off-by: Ajye Huang <ajye_huang@compal.corp-partner.google.com>
> ---
> .../devicetree/bindings/sound/google,sc7180-trogdor.yaml | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml
> index efc34689d6b5..ce050a9dec94 100644
> --- a/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml
> +++ b/Documentation/devicetree/bindings/sound/google,sc7180-trogdor.yaml
> @@ -34,6 +34,10 @@ properties:
> "#size-cells":
> const: 0
>
> + dmic-gpios:
> + maxItems: 1
> + description: GPIO for switching between DMICs
> +
> patternProperties:
> "^dai-link(@[0-9])?$":
> description:
> @@ -83,7 +87,7 @@ examples:
> - |
> sound {
> compatible = "google,sc7180-trogdor";
> - model = "sc7180-rt5682-max98357a-1mic";
> + model = "sc7180-rt5682-max98357a-2mic";
>
> audio-routing =
> "Headphone Jack", "HPOL",
> @@ -92,6 +96,8 @@ examples:
> #address-cells = <1>;
> #size-cells = <0>;
>
> + dmic-gpios = <&tlmm 86 0>;
> +
> dai-link@0 {
> link-name = "MultiMedia0";
> reg = <0>;
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2020-11-09 14:56    [W:0.085 / U:0.848 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site