Messages in this thread Patch in this message | | | Date | Sun, 8 Nov 2020 09:23:17 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH RESEND] driver core: export device_is_bound() to fix build failure |
| |
On Sat, Nov 07, 2020 at 10:47:27PM +0000, Sudip Mukherjee wrote: > When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it > is unable to find device_is_bound(). The error being: > ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko] > undefined! > > Export the symbol so that the module finds it. > > Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support") > Signed-off-by: Sudip Mukherjee <sudipm.mukherjee@gmail.com> > --- > > resending with the Fixes: tag. > > drivers/base/dd.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > index 148e81969e04..a796a57e5efb 100644 > --- a/drivers/base/dd.c > +++ b/drivers/base/dd.c > @@ -353,6 +353,7 @@ bool device_is_bound(struct device *dev) > { > return dev->p && klist_node_attached(&dev->p->knode_driver); > } > +EXPORT_SYMBOL(device_is_bound);
EXPORT_SYMBOL_GPL() please, like all the other exports in this file.
Also, wait, no, don't call this, are you sure you are calling it in a race-free way? And what branch/tree is the above commit in?
thanks,
greg k-h
| |