lkml.org 
[lkml]   [2020]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v6 6/6] dt-bindings: spi: Add compatible for Intel LGM SoC
    From
    Date
    Hi Rob,

    On 5/11/2020 6:03 am, Rob Herring wrote:
    > On Fri, Oct 30, 2020 at 01:31:53PM +0800, Ramuthevar,Vadivel MuruganX wrote:
    >> From: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
    >>
    >> Add compatible for Intel LGM SoC.
    >>
    >> Signed-off-by: Ramuthevar Vadivel Murugan <vadivel.muruganx.ramuthevar@linux.intel.com>
    >> ---
    >> Documentation/devicetree/bindings/spi/cadence-quadspi.yaml | 1 +
    >> 1 file changed, 1 insertion(+)
    >>
    >> diff --git a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml
    >> index ec22b040d804..58ecdab939df 100644
    >> --- a/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml
    >> +++ b/Documentation/devicetree/bindings/spi/cadence-quadspi.yaml
    >> @@ -19,6 +19,7 @@ properties:
    >> - enum:
    >> - ti,k2g-qspi
    >> - ti,am654-ospi
    >> + - intel,lgm-qspi
    >
    > As this change shows, you don't need 'oneOf' for Intel...
    As we you have suggested in the previous mail, I framed like below with
    'oneOf'

    properties:
    compatible:
    oneOf:
    - items:
    - enum:
    - ti,k2g-qspi
    - ti,am654-ospi
    - const: cdns,qspi-nor

    - items:
    - enum:
    - intel,lgm-qspi
    - cadence,qspi #compatible for generic in future use
    - const: cdns,qspi-nor

    so that ignoring error message warning can be avoided as well, Thanks!


    Regards
    Vadivel

    >
    >> - const: cdns,qspi-nor
    >>
    >> reg:
    >> --
    >> 2.11.0
    >>

    \
     
     \ /
      Last update: 2020-11-09 02:50    [W:4.803 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site