Messages in this thread | | | From | Nick Desaulniers <> | Date | Sat, 7 Nov 2020 01:04:47 -0800 | Subject | Re: [PATCH v2] Revert "kbuild: Do not enable -Wimplicit-fallthrough for clang for now" |
| |
On Sat, Nov 7, 2020 at 12:45 AM Nick Desaulniers <ndesaulniers@google.com> wrote: > > This reverts commit e2079e93f562c7f7a030eb7642017ee5eabaaa10. > > This has been fixed up over time thanks to the addition of "fallthrough" > pseudo-keyword in > commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo > keyword for switch/case use") > > Link: https://github.com/ClangBuiltLinux/linux/issues/236 > Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> > --- > Changes V1 -> V2: > * We actually want a revert, not a partial revert. v1 removed > -Wimplicit-fallthrough outright, which we don't want. We still need > cc-option for GCC < 7.
Gah, I tested a ton of configs with V1...but not V2...this patch is not ready yet. Sorry for the noise.
-- Thanks, ~Nick Desaulniers
| |