Messages in this thread Patch in this message | | | From | xiakaixu1987@gmail ... | Subject | [PATCH] proc: fix comparison to bool warning | Date | Sat, 7 Nov 2020 23:30:11 +0800 |
| |
From: Kaixu Xia <kaixuxia@tencent.com>
Fix the following coccicheck warning:
./fs/proc/generic.c:370:5-31: WARNING: Comparison to bool
Reported-by: Tosk Robot <tencent_os_robot@tencent.com> Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> --- fs/proc/generic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/generic.c b/fs/proc/generic.c index 2f9fa179194d..4533eb826af7 100644 --- a/fs/proc/generic.c +++ b/fs/proc/generic.c @@ -367,7 +367,7 @@ struct proc_dir_entry *proc_register(struct proc_dir_entry *dir, write_lock(&proc_subdir_lock); dp->parent = dir; - if (pde_subdir_insert(dir, dp) == false) { + if (!pde_subdir_insert(dir, dp)) { WARN(1, "proc_dir_entry '%s/%s' already registered\n", dir->name, dp->name); write_unlock(&proc_subdir_lock); -- 2.20.0
| |