lkml.org 
[lkml]   [2020]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -next] mm/hugetlb: Make is_aligned_hugepage_range static
    On Thu, Oct 29, 2020 at 10:13:20AM +0800, Zou Wei wrote:
    > Fix the following sparse warning:
    >
    > arch/mips/mm/hugetlbpage.c:64:5: warning:
    > symbol 'is_aligned_hugepage_range' was not declared. Should it be static?
    >
    > Reported-by: Hulk Robot <hulkci@huawei.com>
    > Signed-off-by: Zou Wei <zou_wei@huawei.com>
    > ---
    > arch/mips/mm/hugetlbpage.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/arch/mips/mm/hugetlbpage.c b/arch/mips/mm/hugetlbpage.c
    > index 77ffece..774c988 100644
    > --- a/arch/mips/mm/hugetlbpage.c
    > +++ b/arch/mips/mm/hugetlbpage.c
    > @@ -61,7 +61,7 @@ pte_t *huge_pte_offset(struct mm_struct *mm, unsigned long addr,
    > /*
    > * This function checks for proper alignment of input addr and len parameters.
    > */
    > -int is_aligned_hugepage_range(unsigned long addr, unsigned long len)
    > +static int is_aligned_hugepage_range(unsigned long addr, unsigned long len)

    this should give then a warning that 'is_aligned_hugepage_range' is unused.
    Could you send a patch, which remove function completely ?

    Thomas.

    --
    Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
    good idea. [ RFC1925, 2.3 ]

    \
     
     \ /
      Last update: 2020-11-06 11:54    [W:3.921 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site