Messages in this thread | | | From | Vitaly Kuznetsov <> | Subject | Re: [PATCH] x86/kvm: remove unused macro HV_CLOCK_SIZE | Date | Fri, 06 Nov 2020 10:35:48 +0100 |
| |
Alex Shi <alex.shi@linux.alibaba.com> writes:
> This macro is useless, and could cause gcc warning: > arch/x86/kernel/kvmclock.c:47:0: warning: macro "HV_CLOCK_SIZE" is not > used [-Wunused-macros] > Let's remove it. > > Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com> > Cc: Paolo Bonzini <pbonzini@redhat.com> > Cc: Sean Christopherson <sean.j.christopherson@intel.com> > Cc: Vitaly Kuznetsov <vkuznets@redhat.com> > Cc: Wanpeng Li <wanpengli@tencent.com> > Cc: Jim Mattson <jmattson@google.com> > Cc: Joerg Roedel <joro@8bytes.org> > Cc: Thomas Gleixner <tglx@linutronix.de> > Cc: Ingo Molnar <mingo@redhat.com> > Cc: Borislav Petkov <bp@alien8.de> > Cc: x86@kernel.org > Cc: "H. Peter Anvin" <hpa@zytor.com> > Cc: kvm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > arch/x86/kernel/kvmclock.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/x86/kernel/kvmclock.c b/arch/x86/kernel/kvmclock.c > index 34b18f6eeb2c..aa593743acf6 100644 > --- a/arch/x86/kernel/kvmclock.c > +++ b/arch/x86/kernel/kvmclock.c > @@ -44,7 +44,6 @@ static int __init parse_no_kvmclock_vsyscall(char *arg) > early_param("no-kvmclock-vsyscall", parse_no_kvmclock_vsyscall); > > /* Aligned to page sizes to match whats mapped via vsyscalls to userspace */ > -#define HV_CLOCK_SIZE (sizeof(struct pvclock_vsyscall_time_info) * NR_CPUS) > #define HVC_BOOT_ARRAY_SIZE \ > (PAGE_SIZE / sizeof(struct pvclock_vsyscall_time_info))
Fixes: 95a3d4454bb1 ("x86/kvmclock: Switch kvmclock data to a PER_CPU variable")
where the last and the only user was removed.
Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>
-- Vitaly
| |