Messages in this thread | | | Date | Sat, 7 Nov 2020 00:01:42 +0200 | From | Jarkko Sakkinen <> | Subject | Re: [PATCH v40 11/24] x86/sgx: Add SGX misc driver interface |
| |
On Fri, Nov 06, 2020 at 06:09:20PM +0100, Borislav Petkov wrote: > On Fri, Nov 06, 2020 at 06:07:42PM +0200, Jarkko Sakkinen wrote: > > On Thu, Nov 05, 2020 at 07:10:47PM +0100, Borislav Petkov wrote: > > > On Thu, Nov 05, 2020 at 07:57:45PM +0200, Jarkko Sakkinen wrote: > > > > I'll rather send a full patch set if required. > > > > > > Why if the changes all belong to this patch and why should I take a > > > patch which clearly needs improving? > > > > > > Just send the fixed version of this and I can take it now. > > > > > > Thx. > > > > Here's an update patch. I kept the name as sgx_encl_find() so and output > > argument instead of return value, so that the change is localized. I > > think this is good enough, i.e. the semantically obsolete stuff has been > > wiped off. > > Thanks. > > > Tested-by: Jethro Beekman <jethro@fortanix.com> > > Tested-by: Haitao Huang <haitao.huang@linux.intel.com> > > Tested-by: Chunyang Hui <sanqian.hcy@antfin.com> > > Tested-by: Jordan Hand <jorhand@linux.microsoft.com> > > Tested-by: Nathaniel McCallum <npmccallum@redhat.com> > > Tested-by: Seth Moore <sethmo@google.com> > > Tested-by: Darren Kenny <darren.kenny@oracle.com> > > Btw, you do know that when you change the patch, those tested-by's don't > hold true anymore, right? > > The Reviewed-by's too, actually. > > I'll zap them.
Yes, I know that. That was something that I should have done for this version. I was too busy turning every rock to make everything as clean as possible, sorry about that. I'll also update my tree accordingly.
> -- > Regards/Gruss, > Boris. > > https://people.kernel.org/tglx/notes-about-netiquette
/Jarkko
| |