Messages in this thread | | | Date | Fri, 6 Nov 2020 13:38:58 -0800 | From | Nicolin Chen <> | Subject | Re: [PATCH v3 2/2] ASoC: fsl_aud2htx: Add aud2htx module driver |
| |
On Fri, Nov 06, 2020 at 10:51:03AM +0800, Shengjiu Wang wrote:
> > > +static irqreturn_t fsl_aud2htx_isr(int irq, void *dev_id) > > > +{ > > > + return IRQ_HANDLED; > > > > Empty isr? Perhaps can drop the request_irq() at all? > > I'd like to keep this for future enhancement, what do you think?
I believe that usually it will be a common practice that we add when we use it -- exaggerating the situation, just like you will not actually add an empty driver for future enhancement.
But I am not strongly against it, as it's small. Since Mark has applied it, let's keep it then.
| |