Messages in this thread | | | Subject | Re: [PATCH 5.9 080/391] ASoC: SOF: fix a runtime pm issue in SOF when HDMI codec doesnt work | From | Pierre-Louis Bossart <> | Date | Thu, 5 Nov 2020 10:17:57 -0600 |
| |
>>>> My local build of v5.9.5 broke on this patch. >>>> >>>> sound/soc/sof/intel/hda-codec.c: In function 'hda_codec_probe': >>>> sound/soc/sof/intel/hda-codec.c:177:4: error: label 'error' used but >>>> not defined >>>> 177 | goto error; >>>> | ^~~~ >>>> make[4]: *** [scripts/Makefile.build:283: >>>> sound/soc/sof/intel/hda-codec.o] Error 1 >>>> make[3]: *** [scripts/Makefile.build:500: sound/soc/sof/intel] Error 2 >>>> make[2]: *** [scripts/Makefile.build:500: sound/soc/sof] Error 2 >>>> make[1]: *** [scripts/Makefile.build:500: sound/soc] Error 2 >>>> make: *** [Makefile:1778: sound] Error 2 >>>> >>>> There's indeed no error label in v5.9.5. (There is one in v5.10-rc2, >>>> I just >>>> checked.) Is no-one else running into this? >>> >>> It seems that setting CONFIG_SND_SOC_SOF_HDA_AUDIO_CODEC=y is very >>> "difficult", it's not being set by allmodconfig nor is it easy to >>> manually set it up. >>> >>> I'll revert the patch, but it would be nice to make sure it's easier to >>> test this out too. >> >> this issue comes from out-of-order patches, give me a couple of hours >> to look into this before reverting. thanks! > > Sure! Thanks for looking into this.
I would recommend adding this commit to 5.9-stable:
11ec0edc6408a ('ASOC: SOF: Intel: hda-codec: move unused label to correct position')
I just tried with 5.9.5 and the compilation error is solved with this commit.
It was initially intended to solve a minor 'defined but not used' issue, which somehow became a bad 'used but not defined' one. Probably a bad git merge I did, sorry about that.
Thanks! -Pierre
| |