Messages in this thread | | | From | Brendan Higgins <> | Date | Thu, 5 Nov 2020 08:05:51 -0800 | Subject | Re: [PATCH] kunit: fix display of failed expectations for strings |
| |
On Mon, Nov 2, 2020 at 3:23 PM Daniel Latypov <dlatypov@google.com> wrote: > > Currently the following expectation > KUNIT_EXPECT_STREQ(test, "hi", "bye"); > will produce: > Expected "hi" == "bye", but > "hi" == 1625079497 > "bye" == 1625079500 > > After this patch: > Expected "hi" == "bye", but > "hi" == hi > "bye" == bye > > KUNIT_INIT_BINARY_STR_ASSERT_STRUCT() was written but just mistakenly > not actually used by KUNIT_EXPECT_STREQ() and friends. > > Signed-off-by: Daniel Latypov <dlatypov@google.com>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com> Tested-by: Brendan Higgins <brendanhiggins@google.com>
| |