lkml.org 
[lkml]   [2020]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID
Date


> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 2020年11月5日 16:26
> To: Alice Guo <alice.guo@nxp.com>
> Cc: robh+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
> dl-linux-imx <linux-imx@nxp.com>; Peng Fan <peng.fan@nxp.com>;
> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> linux-arm-kernel@lists.infradead.org
> Subject: [EXT] Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc
> for soc unique ID
>
> Caution: EXT Email
>
> On Thu, Nov 05, 2020 at 03:26:26PM +0800, Alice Guo wrote:
> > Add DT Binding doc for the Unique ID of i.MX 8M series.
> >
> > Signed-off-by: Alice Guo <alice.guo@nxp.com>
> > ---
> > .../devicetree/bindings/arm/fsl.yaml | 33
> +++++++++++++++++++
> > 1 file changed, 33 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> b/Documentation/devicetree/bindings/arm/fsl.yaml
> > index e4db0f9ed664..0419f078502b 100644
> > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > @@ -901,6 +901,39 @@ properties:
> > - fsl,s32v234-evb # S32V234-EVB2 Customer
> Evaluation Board
> > - const: fsl,s32v234
> >
> > + soc:
> > + description:
> > + i.MX8M Family SoC must provide a soc node in the root of the device
> tree,
> > + representing the System-on-Chip since these test chips are rather
> complex.
> > + type: object
> > + properties:
> > + compatible:
> > + oneOf:
> > + - items:
> > + - const: fsl,imx8mm-soc
> > + - const: simple-bus
> > + - items:
> > + - const: fsl,imx8mn-soc
> > + - const: simple-bus
> > + - items:
> > + - const: fsl,imx8mp-soc
> > + - const: simple-bus
> > + - items:
> > + - const: fsl,imx8mq-soc
> > + - const: simple-bus
> > +
> > + nvmem-cells:
> > + maxItems: 1
> > + description: Phandle to the SOC Unique ID provided by a nvmem
> node
> > +
> > + nvmem-cells-names:
> > + const: soc_unique_id
> > +
> > + required:
> > + - compatible
> > + - nvmem-cells
> > + - nvmem-cell-names
> > +
>
> Did you actually test it? I see multiple errors with this patch.
> fsl-ls1012a-frdm.dt.yaml: /: soc:compatible: ['simple-bus'] is not valid under any
> of the given schemas
>
> Best regards,
> Krzysztof


[Alice Guo] Sorry. I did not see errors what you said. Can you tell me how did you test it?

Best regards,
Alice Guo

\
 
 \ /
  Last update: 2020-11-05 13:21    [W:0.105 / U:0.316 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site