Messages in this thread | | | Date | Thu, 05 Nov 2020 12:08:21 +0000 | From | Marc Zyngier <> | Subject | Re: [PATCH v2 3/5] gpio: msc313: MStar MSC313 GPIO driver |
| |
On 2020-11-05 09:40, Linus Walleij wrote: > On Mon, Oct 19, 2020 at 4:10 PM Daniel Palmer <daniel@0x0f.com> wrote:
[...]
>> +/* The parent interrupt controller needs the GIC interrupt type set >> to GIC_SPI >> + * so we need to provide the fwspec. Essentially >> gpiochip_populate_parent_fwspec_twocell >> + * that puts GIC_SPI into the first cell. >> + */
nit: comment style.
>> +static void *msc313_gpio_populate_parent_fwspec(struct gpio_chip *gc, >> + unsigned int >> parent_hwirq, >> + unsigned int parent_type) >> +{ >> + struct irq_fwspec *fwspec; >> + >> + fwspec = kmalloc(sizeof(*fwspec), GFP_KERNEL); >> + if (!fwspec) >> + return NULL; >> + >> + fwspec->fwnode = gc->irq.parent_domain->fwnode; >> + fwspec->param_count = 3; >> + fwspec->param[0] = GIC_SPI; >> + fwspec->param[1] = parent_hwirq; >> + fwspec->param[2] = parent_type; >> + >> + return fwspec; >> +} > > Clever. Looping in Marc Z so he can say if this looks allright to him.
Yup, this looks correct. However, looking at the bit of the patch that isn't quoted here, I see that msc313_gpio_irqchip doesn't have a .irq_set_affinity callback. Is this system UP only?
Thanks,
M. -- Jazz is not dead. It just smells funny...
| |