Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Thu, 5 Nov 2020 09:56:21 +0100 | Subject | Re: [RFT PATCH v2 7/8] gpio: exar: switch to using regmap |
| |
On Wed, Nov 4, 2020 at 9:35 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > > On Wed, Nov 4, 2020 at 9:34 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > ... > > > +static const struct regmap_config exar_regmap_config = { > > + .name = "exar-gpio", > > + .reg_bits = 8, > > + .val_bits = 8, > > +}; > > Looking at gpio-pca953xx regmap conversion I'm wondering shouldn't you > provide a callback to define volatile registers (such as GPIO input > bits)? > > -- > With Best Regards, > Andy Shevchenko
I think this was done in pca953x due to weird calculations of banks and registers. For a rather simple driver like this one I don't think this is needed.
Bartosz
| |