Messages in this thread | | | Date | Thu, 5 Nov 2020 08:39:32 +0000 | From | Lee Jones <> | Subject | Re: [PATCH 31/36] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location |
| |
On Thu, 05 Nov 2020, Michael Ellerman wrote:
> Lee Jones <lee.jones@linaro.org> writes: > > Fixes the following W=1 kernel build warning(s): > > > > drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for ‘hvc_vio_init_early’ [-Wmissing-prototypes] > > 385 | void __init hvc_vio_init_early(void) > > | ^~~~~~~~~~~~~~~~~~ > > > > Cc: Michael Ellerman <mpe@ellerman.id.au> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > > Cc: Paul Mackerras <paulus@samba.org> > > Cc: linuxppc-dev@lists.ozlabs.org > > Signed-off-by: Lee Jones <lee.jones@linaro.org> > > --- > > arch/powerpc/include/asm/hvconsole.h | 3 +++ > > arch/powerpc/platforms/pseries/pseries.h | 3 --- > > arch/powerpc/platforms/pseries/setup.c | 1 + > > 3 files changed, 4 insertions(+), 3 deletions(-) > > Acked-by: Michael Ellerman <mpe@ellerman.id.au>
Thanks.
> > diff --git a/arch/powerpc/include/asm/hvconsole.h b/arch/powerpc/include/asm/hvconsole.h > > index 999ed5ac90531..936a1ee1ac786 100644 > > --- a/arch/powerpc/include/asm/hvconsole.h > > +++ b/arch/powerpc/include/asm/hvconsole.h > > @@ -24,5 +24,8 @@ > > extern int hvc_get_chars(uint32_t vtermno, char *buf, int count); > > extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count); > > > > +/* Provided by HVC VIO */ > > +extern void hvc_vio_init_early(void); > > extern isn't needed, but don't feel you need to respin just to drop it.
That's fine. I don't mind re-spinning.
-- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
| |