lkml.org 
[lkml]   [2020]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] arm64: Fix a broken copyright header in gen_vdso_offsets.sh
From
On Tue, 20 Oct 2020 04:32:08 PDT (-0700), will@kernel.org wrote:
> On Fri, Oct 16, 2020 at 05:26:37PM -0700, Palmer Dabbelt wrote:
>> From: Palmer Dabbelt <palmerdabbelt@google.com>
>>
>> I was going to copy this but I didn't want to chase around the build
>> system stuff so I did it a different way.
>
> How did you end up doing it? I remember trying to parse the ELF object at
> one time of day and not getting very far.

Mine really isn't any cleaner: I use nm and sed to produce an assembler file
full of absolute symbols, which I compile to produce the object. That way I
don't need a header file, which means I don't need to mess around with build
ordering or change any of the other code (which was already using symbols).

I don't really like this whole thing we do where we just assume that symbols
with a small offset from absolute address zero. We're sort of depending on
that for undefined weak symbols, but that's only for actually zero not almost
zero. Given that, I figured it'd be easier to just do it this way rather than
trying to mess with build stuff.

I probably wouldn't bother changing unless there's something actively bad about
that build stuff (I didn't really look).

\
 
 \ /
  Last update: 2020-11-06 03:49    [W:0.094 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site