lkml.org 
[lkml]   [2020]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] selftests/exec: Fix building of exec test
On Wed, Nov 04, 2020 at 09:07:06PM +1100, Michael Ellerman wrote:
> Currently the exec test does not build:
>
> make[1]: Entering directory '/linux/tools/testing/selftests/exec'
> ...
> make[1]: *** No rule to make target '/output/kselftest/exec/pipe', needed by 'all'.
>
> This is because pipe is listed in TEST_GEN_FILES, but pipe is not
> generated by the Makefile, it's created at runtime. So drop pipe from
> TEST_GEN_FILES.

Ah, yes, shouldn't it be added to EXTRA_CLEAN though?

Fixes: 61016db15b8e ("selftests/exec: Verify execve of non-regular files fail")

>
> With that fixed, then install fails:
>
> make[1]: Entering directory '/linux/tools/testing/selftests/exec'
> rsync -a binfmt_script non-regular /output/install/exec/
> rsync: link_stat "/linux/tools/testing/selftests/exec/non-regular" failed: No such file or directory (2)
>
> That's because non-regular hasn't been built, because it's in
> TEST_PROGS, it should be part of TEST_GEN_PROGS to indicate that it
> needs to be built.

Yes, thanks again!

Fixes: 0f71241a8e32 ("selftests/exec: add file type errno tests")

for both:

Acked-by: Kees Cook <keescook@chromium.org>

--
Kees Cook

\
 
 \ /
  Last update: 2020-11-04 20:07    [W:0.033 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site