Messages in this thread Patch in this message | | | Date | Wed, 4 Nov 2020 20:05:15 +0100 | From | Maxime Ripard <> | Subject | Re: [PATCH v2 5/6] ARM: dts: sun8i: s3: Add dts for the Elimo Initium SBC |
| |
On Tue, Nov 03, 2020 at 04:33:26PM +0000, Matteo Scordino wrote: > > > > > sun8i-t3-cqa3t-bv3.dtb \ > > > sun8i-v3s-licheepi-zero.dtb \ > > > sun8i-v3s-licheepi-zero-dock.dtb \ > > > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts > > > new file mode 100644 > > > index 000000000000..7677ddc07bf9 > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-initium.dts > > > @@ -0,0 +1,28 @@ > > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > > +/* > > > + * Copyright (C) 2020 Matteo Scordino <matteo@elimo.io> > > > + */ > > > + > > > +/dts-v1/; > > > +#include "sun8i-s3-elimo-impetus.dtsi" > > > + > > > +/ { > > > + model = "Elimo Initium"; > > > + compatible = "elimo,initium", "elimo,impetus", "sochip,s3", > > > + "allwinner,sun8i-v3"; > > You should indent that properly > > Double ouch. > However, how is a multiline dt property supposed to be indented? > I have tried a few combinations but nothing seemed to make checkpatch.pl happy, > except leaving no space at all at the beginning of the line. But I think makes it > quite unreadable?
We usually pad with tabs, then spaces to match the opening quotes, like
compatible = "elimo,initium", "elimo,impetus", "sochip,s3", "allwinner,sun8i-v3";
Maxime [unhandled content-type:application/pgp-signature] | |