Messages in this thread | | | Date | Wed, 4 Nov 2020 17:59:10 +0100 | From | Greg KH <> | Subject | Re: [PATCH] USB: serial: mos7720: fix parallel-port state restore |
| |
On Wed, Nov 04, 2020 at 05:47:27PM +0100, Johan Hovold wrote: > The parallel-port restore operations is called when a driver claims the > port and is supposed to restore the provided state (e.g. saved when > releasing the port). > > Fixes: b69578df7e98 ("USB: usbserial: mos7720: add support for parallel port on moschip 7715") > Cc: stable <stable@vger.kernel.org> # 2.6.35 > Signed-off-by: Johan Hovold <johan@kernel.org> > --- > drivers/usb/serial/mos7720.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c > index 5eed1078fac8..5a5d2a95070e 100644 > --- a/drivers/usb/serial/mos7720.c > +++ b/drivers/usb/serial/mos7720.c > @@ -639,6 +639,8 @@ static void parport_mos7715_restore_state(struct parport *pp, > spin_unlock(&release_lock); > return; > } > + mos_parport->shadowDCR = s->u.pc.ctr; > + mos_parport->shadowECR = s->u.pc.ecr;
Wow that's old code. I'm guessing no one uses these devices really :(
Anyway, nice work:
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> write_parport_reg_nonblock(mos_parport, MOS7720_DCR, > mos_parport->shadowDCR); > write_parport_reg_nonblock(mos_parport, MOS7720_ECR, > -- > 2.26.2 >
| |