Messages in this thread | | | Date | Wed, 4 Nov 2020 15:03:18 +0100 | From | Guennadi Liakhovetski <> | Subject | Re: [PATCH v4 3/8] rpmsg: Move structure rpmsg_ns_msg to header file |
| |
A nitpick to this one:
On Tue, Oct 27, 2020 at 11:52:13AM -0600, Mathieu Poirier wrote: > Move structure rpmsg_ns_msg to its own header file so that > it can be used by other entities. > > Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org> > Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com> > ---
[snip]
> diff --git a/include/linux/rpmsg_ns.h b/include/linux/rpmsg_ns.h > new file mode 100644 > index 000000000000..bb479f430080 > --- /dev/null > +++ b/include/linux/rpmsg_ns.h > @@ -0,0 +1,42 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > + > +#ifndef _LINUX_RPMSG_NS_H > +#define _LINUX_RPMSG_NS_H > + > +#include <linux/mod_devicetable.h> > +#include <linux/types.h> > +#include <linux/rpmsg_byteorder.h>
would be good to sort these alphabetically.
Thanks Guennadi
| |