Messages in this thread | | | Date | Wed, 4 Nov 2020 12:59:03 +0100 | From | Greg Kroah-Hartman <> | Subject | Re: Re: [PATCH 0/2] drivers/tty: delete break after return or goto |
| |
On Wed, Nov 04, 2020 at 07:17:56PM +0800, Bernard wrote: > > > From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Date: 2020-11-04 19:02:53 > To: Bernard Zhao <bernard@vivo.com> > Cc: Jiri Slaby <jirislaby@kernel.org>,Shawn Guo <shawnguo@kernel.org>,Sascha Hauer <s.hauer@pengutronix.de>,Pengutronix Kernel Team <kernel@pengutronix.de>,Fabio Estevam <festevam@gmail.com>,NXP Linux Team <linux-imx@nxp.com>,linux-kernel@vger.kernel.org,linux-serial@vger.kernel.org,linux-arm-kernel@lists.infradead.org,opensource.kernel@vivo.com > Subject: Re: [PATCH 0/2] drivers/tty: delete break after return or goto>On Wed, Nov 04, 2020 at 02:53:29AM -0800, Bernard Zhao wrote: > >> This patch sereies optimise code like: > >> { > >> case XXX: > >> return XXX; > >> break; //The break is meanless, so just delete it. > >> case YYY: > >> goto YYY; > >> break; //The break is meanless, so just delete it. > >> ...... > >> } > >> > >> Signed-off-by: Bernard Zhao <bernard@vivo.com> > >> > >> --- > >> Bernard Zhao (2): > >> drivers/tty/nozomi.c: delete no use break after goto > >> drivers/tty/serial/imx.c: delete no use break after return > > > >That is not the subject of the patches you sent out, what broke? > > Hi: > > I am sorry that I am a little confused: > The patch series`s subject is "drivers/tty: delete break after return or goto" > and the blurb is: > This patch sereies optimise code like: > { > case XXX: > return XXX; > break; //The break is meanless, so just delete it. > case YYY: > goto YYY; > break; //The break is meanless, so just delete it. > ...... > } > last, the modified files are: > Bernard Zhao (2): > drivers/tty/nozomi.c: delete no use break after goto > drivers/tty/serial/imx.c: delete no use break after return > > Is there something wrong that I didn`t catch?
The above lines do not match up with the subject lines of the patches you sent out, so something went wrong.
thanks,
greg k-h
| |