lkml.org 
[lkml]   [2020]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] clk: ingenic/TCU: Remove NULL pointer check before clk_enable/disable
Hi,

Le mer. 4 nov. 2020 à 7:11, Xu Wang <vulab@iscas.ac.cn> a écrit :
> Because clk_enable and clk_disable already checked NULL clock
> parameter,
> so the additional checks are unnecessary, just remove them.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Reviewed-by: Paul Cercueil <paul@crapouillou.net>

Cheers,
-Paul

> ---
> drivers/clk/ingenic/tcu.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/clk/ingenic/tcu.c b/drivers/clk/ingenic/tcu.c
> index 9382dc3aa27e..ffcb3667fd2b 100644
> --- a/drivers/clk/ingenic/tcu.c
> +++ b/drivers/clk/ingenic/tcu.c
> @@ -445,8 +445,7 @@ static int __maybe_unused tcu_pm_suspend(void)
> {
> struct ingenic_tcu *tcu = ingenic_tcu;
>
> - if (tcu->clk)
> - clk_disable(tcu->clk);
> + clk_disable(tcu->clk);
>
> return 0;
> }
> @@ -455,8 +454,7 @@ static void __maybe_unused tcu_pm_resume(void)
> {
> struct ingenic_tcu *tcu = ingenic_tcu;
>
> - if (tcu->clk)
> - clk_enable(tcu->clk);
> + clk_enable(tcu->clk);
> }
>
> static struct syscore_ops __maybe_unused tcu_pm_ops = {
> --
> 2.17.1
>


\
 
 \ /
  Last update: 2020-11-04 12:19    [W:0.027 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site