Messages in this thread | | | From | Nick Desaulniers <> | Date | Wed, 4 Nov 2020 16:35:04 -0800 | Subject | Re: [RFC PATCH] .clang-format: Remove conditional comments |
| |
On Tue, Nov 3, 2020 at 5:31 PM Joe Perches <joe@perches.com> wrote: > > On Tue, 2020-11-03 at 17:08 -0800, Nick Desaulniers wrote: > > On Tue, Nov 3, 2020 at 1:33 PM Miguel Ojeda > > <miguel.ojeda.sandonis@gmail.com> wrote: > > > On Tue, Nov 3, 2020 at 7:29 PM Joe Perches <joe@perches.com> wrote: > > > > > > > > Now that the clang minimum supported version is > 10.0, enable the > > > > commented out conditional reformatting key:value lines in the file. > > > > > > > > Signed-off-by: Joe Perches <joe@perches.com> > > > > --- > > > > > > > > Hey Miguel. > > > > > > > > I don't use this, but on its face it seems a reasonable change > > > > if the commented out key:value lines are correct. > > > > Joe, > > what would it take to get you to use clang-format, or at least try it? > > Beers? Bribes? Dirty deeds, done dirt cheap? > > Hey Nick. > > Paint my house? ;)
I'll help you paint your bikeshed. Oh, but what color? I see a red door, and I want it painted black.
Sounds to me like Miguel could win over a critic by addressing some of your (quite valid) concerns. ;) -- Thanks, ~Nick Desaulniers
| |