Messages in this thread | | | From | Peng Fan <> | Subject | RE: [PATCH v1 1/4] LF-2571-1: dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID | Date | Wed, 4 Nov 2020 08:04:39 +0000 |
| |
> Subject: Re: [PATCH v1 1/4] LF-2571-1: dt-bindings: soc: imx8m: add DT > Binding doc for soc unique ID > > On Wed, 4 Nov 2020 at 04:09, Alice Guo <alice.guo@nxp.com> wrote: > > > > Add DT Binding doc for the Unique ID of i.MX 8M series. > > > > Signed-off-by: Alice Guo <alice.guo@nxp.com> > > --- > > .../bindings/soc/imx/imx8m-unique-id.yaml | 32 > +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/soc/imx/imx8m-unique-id.yaml > > > > diff --git > > a/Documentation/devicetree/bindings/soc/imx/imx8m-unique-id.yaml > > b/Documentation/devicetree/bindings/soc/imx/imx8m-unique-id.yaml > > new file mode 100644 > > index 000000000000..f1e45458cec7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/imx/imx8m-unique-id.yaml > > @@ -0,0 +1,32 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Farm%2Fnxp%2Fimx8m-unique-id.yaml%23& > ;data=0 > > > +4%7C01%7Cpeng.fan%40nxp.com%7Ccd23b4c8f61c4cea5fec08d8809774b7 > %7C686e > > > +a1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637400735282634119%7C > Unknown%7 > > > +CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haW > wiLCJX > > > +VCI6Mn0%3D%7C1000&sdata=I8IcySWYAmFhlm7xNoUyptxR2cxMAfY > APv6bf%2Bp > > +cHG8%3D&reserved=0 > > +$schema: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=04%7C01%7Cpe > ng.fan% > > > +40nxp.com%7Ccd23b4c8f61c4cea5fec08d8809774b7%7C686ea1d3bc2b4c6 > fa92cd9 > > > +9c5c301635%7C0%7C0%7C637400735282634119%7CUnknown%7CTWFpb > GZsb3d8eyJWI > > > +joiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7 > C1000& > > > +amp;sdata=m8T4UAOIn3fDhO5OUrXygT%2BRmwwZXQW9dC5zFQaXl9Q%3 > D&reserv > > +ed=0 > > + > > +title: NXP i.MX8M Platforms Device Tree Bindings > > This is not a title for these bindings. Please describe the bindings for this > device. Based on description, this might could go to bindings/nvmem > directory.
It might be misleading here. I think the bindings is for SoC, just like "arm,realview-eb-soc" in Documentation/devicetree/bindings/arm/arm,realview.yaml
Reading the patch, it is to convert soc-imx8m.c to platform driver, so need to add a compatible string for the soc device, I think Documentation/devicetree/bindings/arm/fsl.yaml should be a better place.
Regards, Peng.
> > > + > > +properties: > > + compatible: > > + oneOf: > > No need for oneOf. > > > + - items: > > + - enum: > > + - fsl,imx8mm-soc > > + - fsl,imx8mn-soc > > + - fsl,imx8mp-soc > > + - fsl,imx8mq-soc > > + - const: simple-bus > > + > > + nvmem-cells: > > + maxItems: 1 > > + description: > > + Reference to an nvmem node for the SOC Unique ID. > > Misleading description - nvmem-cells do not contain a reference. Just skip it, > nvmem-cells should be obvious from the nvmem provider bindings. > > > + > > + nvmem-cells-names: > > + const: soc_unique_id > > additionalProperties: false > > > Best regards, > Krzysztof
| |