Messages in this thread | | | From | Andy Shevchenko <> | Date | Mon, 30 Nov 2020 20:27:54 +0200 | Subject | Re: [PATCH 2/5] serial: core: add sysfs attribute to suppress ready signalling on open |
| |
On Mon, Nov 30, 2020 at 5:42 PM Johan Hovold <johan@kernel.org> wrote: > > Add a nordy sysfs attribute to suppress raising the modem-control lines > on open to signal DTE readiness.
Why not call it nomctrl ?
> This can be use to prevent undesirable side-effects on open for
used
> applications where the DTR and RTS lines are used for non-standard > purposes such as generating power-on and reset pulses.
...
> +static ssize_t nordy_store(struct device *dev, struct device_attribute *attr, > + const char *buf, size_t count) > +{ > + struct tty_port *port = dev_get_drvdata(dev); > + unsigned int val; > + int ret; > + > + ret = kstrtouint(buf, 0, &val); > + if (ret) > + return ret;
> + if (val > 1) > + return -EINVAL;
Can't we utilise kstrtobool() instead?
> + tty_port_set_nordy(port, val); > + > + return count; > +}
-- With Best Regards, Andy Shevchenko
| |