Messages in this thread Patch in this message | | | Subject | Re: [PATCH] checkpatch: fix TYPO_SPELLING check for words with apostrophe | From | Joe Perches <> | Date | Mon, 30 Nov 2020 10:01:12 -0800 |
| |
On Mon, 2020-11-30 at 23:02 +0530, Dwaipayan Ray wrote: > Sorry I think i explained wrong. For words like "doesn't", it still > has the same problem.
I think you explained it wrong when you didn't mention this is _only_ a problem when using --codespell.
Likely it'd be better to use "(?:^|\s)($misspellings)(?=\s|$)"
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 7dc094445d83..b1783f02f745 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -3106,7 +3106,7 @@ sub process { # Check for various typo / spelling mistakes if (defined($misspellings) && ($in_commit_log || $line =~ /^(?:\+|Subject:)/i)) { - while ($rawline =~ /(?:^|[^a-z@])($misspellings)(?:\b|$|[^a-z@])/gi) { + while ($rawline =~ /(?:^|\s)($misspellings)(?=\s|$)/gi) { my $typo = $1; my $typo_fix = $spelling_fix{lc($typo)}; $typo_fix = ucfirst($typo_fix) if ($typo =~ /^[A-Z]/); $ cat t_spell.c // SPDX-License-Identifier: GPL-2.0-only void foo(void) { //misspelled doesn' doesn't arne't word } $ ./scripts/checkpatch.pl -f --strict t_spell.c --codespell --codespellfile /usr/lib/python3/dist-packages/codespell_lib/data/dictionary.txt CHECK: 'doesn'' may be misspelled - perhaps 'doesn't'? #4: FILE: t_spell.c:4: + //misspelled doesn' doesn't arne't word CHECK: 'arne't' may be misspelled - perhaps 'aren't'? #4: FILE: t_spell.c:4: + //misspelled doesn' doesn't arne't word total: 0 errors, 0 warnings, 2 checks, 5 lines checked
NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace.
t_spell.c has style problems, please review.
NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS.
| |