lkml.org 
[lkml]   [2020]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] dt-bindings: phy: bcm-ns-usb3-phy: convert to yaml
From
Date
On 30.11.2020 16:58, Rafał Miłecki wrote:
> On 30.11.2020 16:43, Vinod Koul wrote:
>> On 16-11-20, 08:46, Rafał Miłecki wrote:
>>> From: Rafał Miłecki <rafal@milecki.pl>
>>>
>>> 1. Change syntax from txt to yaml
>>> 2. Drop "Driver for" from the title
>>> 3. Drop "reg = <0x0>;" from example (noticed by dt_binding_check)
>>> 4. Specify license
>>>
>>> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
>>> ---
>>> I think this should go through linux-phy tree. Kishon, Vinod, can you
>>> take this patch?
>>>
>>> This patch generates a false positive checkpatch.pl warning [0].
>>> Please ignore:
>>> WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
>>
>> I am seeing warnings for indentation:
>>
>> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:19:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:20:12: [warning] wrong indentation: expected 12 but found 11 (indentation)
>> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:26:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:30:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:51:6: [warning] wrong indentation: expected 4 but found 5 (indentation)
>> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:71:11: [warning] wrong indentation: expected 9 but found 10 (indentation)
>> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:80:11: [warning] wrong indentation: expected 9 but found 10 (indentation)
>> Documentation/devicetree/bindings/phy/brcm,sata-phy.yaml:88:11: [warning] wrong indentation: expected 9 but found 10 (indentation)
>>
>> Can you pls fix those as well
>
> Sure, just note, it's a different YAML file (I missed that initially and was
> triple checking my bcm-ns-usb3-phy.yaml ;) ). So I'll handle it using a
> different patch.

Oh, that file doesn't actualy exist in tree yet. I guess you meant to reply to Florian's patch
[PATCH] dt-bindings: phy: Convert Broadcom SATA PHY to YAML

\
 
 \ /
  Last update: 2020-11-30 17:02    [W:0.045 / U:0.504 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site