Messages in this thread | | | From | Daniel Palmer <> | Date | Mon, 30 Nov 2020 23:11:58 +0900 | Subject | Re: [PATCH 8/9] ARM: mstar: Add smp ctrl registers to infinity2m dtsi |
| |
Hi Arnd,
On Mon, 30 Nov 2020 at 22:44, Arnd Bergmann <arnd@kernel.org> wrote: > > On Mon, Nov 30, 2020 at 2:10 PM Daniel Palmer <daniel@0x0f.com> wrote: > > > > +&riu { > > + smpctrl@204000 { > > + compatible = "mstar,smpctrl"; > > + reg = <0x204000 0x200>; > > + status = "okay"; > > + }; > > You probably want some more specific compatible value, in case there are > multiple SoCs from mstar that have an smpctrl block and they don't all use > an exactly identical register layout. >
From what I can tell these are in the same place for the infinity2m and the other SMP chip in this series that are in the infinity6 series.
Would "mstar,i2m-smpctrl" make more sense?
Thanks,
Daniel
| |