Messages in this thread | | | Subject | Re: [PATCH] NFC: nxp-nci: Make firmware GPIO pin optional | From | Frieder Schrempf <> | Date | Mon, 30 Nov 2020 12:49:17 +0100 |
| |
On 30.11.20 12:44, Andy Shevchenko wrote: > On Mon, Nov 30, 2020 at 1:06 PM Schrempf Frieder > <frieder.schrempf@kontron.de> wrote: >> >> From: Frieder Schrempf <frieder.schrempf@kontron.de> >> >> There are other NXP NCI compatible NFC controllers such as the PN7150 >> that use an integrated firmware and therefore do not have a GPIO to >> select firmware downloading mode. To support these kind of chips, >> let's make the firmware GPIO optional. > > ... > >> - gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0); >> + if (phy->gpiod_fw) >> + gpiod_set_value(phy->gpiod_fw, (mode == NXP_NCI_MODE_FW) ? 1 : 0); > > This change is not needed.
Indeed, thanks!
| |