Messages in this thread | | | Date | Mon, 30 Nov 2020 12:10:15 +0100 | From | Stefano Garzarella <> | Subject | Re: [PATCH v2 02/17] vdpa_sim: remove unnecessary headers inclusion |
| |
On Mon, Nov 30, 2020 at 11:04:49AM +0800, Jason Wang wrote: > >On 2020/11/26 下午10:49, Stefano Garzarella wrote: >>Some headers are not necessary, so let's remove them to do >>some cleaning. >> >>Signed-off-by: Stefano Garzarella <sgarzare@redhat.com> >>--- >> drivers/vdpa/vdpa_sim/vdpa_sim.c | 13 ------------- >> 1 file changed, 13 deletions(-) >> >>diff --git a/drivers/vdpa/vdpa_sim/vdpa_sim.c b/drivers/vdpa/vdpa_sim/vdpa_sim.c >>index 6a90fdb9cbfc..c6eaf62df8ec 100644 >>--- a/drivers/vdpa/vdpa_sim/vdpa_sim.c >>+++ b/drivers/vdpa/vdpa_sim/vdpa_sim.c >>@@ -7,24 +7,11 @@ >> * >> */ >>-#include <linux/init.h> >> #include <linux/module.h> >>-#include <linux/device.h> > > >I think the rule is to make sure e.g the structure definition can be >via direct inclusion. E.g struct device {} is defined in this file. > > >>-#include <linux/kernel.h> >>-#include <linux/fs.h> >>-#include <linux/poll.h> >>-#include <linux/slab.h> >>-#include <linux/sched.h> >>-#include <linux/wait.h> >>-#include <linux/uuid.h> >>-#include <linux/iommu.h> >> #include <linux/dma-map-ops.h> >>-#include <linux/sysfs.h> >>-#include <linux/file.h> >> #include <linux/etherdevice.h> >> #include <linux/vringh.h> >> #include <linux/vdpa.h> >>-#include <linux/virtio_byteorder.h> > > >And the __cpu_to_virtio16 is defined in this file. >
Okay, I'll keep this two includes and check better the others.
Thanks, Stefano
| |