lkml.org 
[lkml]   [2020]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 29/40] drm/amd/amdgpu/vcn_v1_0: Fix a few kernel-doc misdemeanours
    On Tue, Nov 24, 2020 at 2:45 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:439: warning: Excess function parameter 'sw' description in 'vcn_v1_0_disable_clock_gating'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:566: warning: Excess function parameter 'sw' description in 'vcn_v1_0_enable_clock_gating'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1454: warning: Function parameter or member 'addr' not described in 'vcn_v1_0_dec_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1454: warning: Function parameter or member 'seq' not described in 'vcn_v1_0_dec_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1454: warning: Function parameter or member 'flags' not described in 'vcn_v1_0_dec_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1454: warning: Excess function parameter 'fence' description in 'vcn_v1_0_dec_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1495: warning: Function parameter or member 'job' not described in 'vcn_v1_0_dec_ring_emit_ib'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1495: warning: Function parameter or member 'flags' not described in 'vcn_v1_0_dec_ring_emit_ib'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1628: warning: Function parameter or member 'addr' not described in 'vcn_v1_0_enc_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1628: warning: Function parameter or member 'seq' not described in 'vcn_v1_0_enc_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1628: warning: Function parameter or member 'flags' not described in 'vcn_v1_0_enc_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1628: warning: Excess function parameter 'fence' description in 'vcn_v1_0_enc_ring_emit_fence'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1655: warning: Function parameter or member 'job' not described in 'vcn_v1_0_enc_ring_emit_ib'
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c:1655: warning: Function parameter or member 'flags' not described in 'vcn_v1_0_enc_ring_emit_ib'
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied with minor fixes. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 14 ++++++++++----
    > 1 file changed, 10 insertions(+), 4 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
    > index 86e1ef732ebec..72148f3b27d04 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
    > @@ -431,7 +431,6 @@ static void vcn_v1_0_mc_resume_dpg_mode(struct amdgpu_device *adev)
    > * vcn_v1_0_disable_clock_gating - disable VCN clock gating
    > *
    > * @adev: amdgpu_device pointer
    > - * @sw: enable SW clock gating
    > *
    > * Disable clock gating for VCN block
    > */
    > @@ -558,7 +557,6 @@ static void vcn_v1_0_disable_clock_gating(struct amdgpu_device *adev)
    > * vcn_v1_0_enable_clock_gating - enable VCN clock gating
    > *
    > * @adev: amdgpu_device pointer
    > - * @sw: enable SW clock gating
    > *
    > * Enable clock gating for VCN block
    > */
    > @@ -1445,7 +1443,9 @@ static void vcn_v1_0_dec_ring_insert_end(struct amdgpu_ring *ring)
    > * vcn_v1_0_dec_ring_emit_fence - emit an fence & trap command
    > *
    > * @ring: amdgpu_ring pointer
    > - * @fence: fence to emit
    > + * @addr: address
    > + * @seq: sequence number
    > + * @flags: fence related flags
    > *
    > * Write a fence and a trap command to the ring.
    > */
    > @@ -1484,7 +1484,9 @@ static void vcn_v1_0_dec_ring_emit_fence(struct amdgpu_ring *ring, u64 addr, u64
    > * vcn_v1_0_dec_ring_emit_ib - execute indirect buffer
    > *
    > * @ring: amdgpu_ring pointer
    > + * @job: job to retrive vmid from
    > * @ib: indirect buffer to execute
    > + * @flags: unused
    > *
    > * Write ring commands to execute the indirect buffer
    > */
    > @@ -1619,7 +1621,9 @@ static void vcn_v1_0_enc_ring_set_wptr(struct amdgpu_ring *ring)
    > * vcn_v1_0_enc_ring_emit_fence - emit an enc fence & trap command
    > *
    > * @ring: amdgpu_ring pointer
    > - * @fence: fence to emit
    > + * @addr: address
    > + * @seq: sequence number
    > + * @flags: fence related flags
    > *
    > * Write enc a fence and a trap command to the ring.
    > */
    > @@ -1644,7 +1648,9 @@ static void vcn_v1_0_enc_ring_insert_end(struct amdgpu_ring *ring)
    > * vcn_v1_0_enc_ring_emit_ib - enc execute indirect buffer
    > *
    > * @ring: amdgpu_ring pointer
    > + * @job: job to retrive vmid from
    > * @ib: indirect buffer to execute
    > + * @flags: unused
    > *
    > * Write enc ring commands to execute the indirect buffer
    > */
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-30 23:45    [W:2.327 / U:0.416 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site