lkml.org 
[lkml]   [2020]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 10/40] drm/amd/amdgpu/navi10_ih: Add descriptions for 'ih' and 'entry'
    On Tue, Nov 24, 2020 at 2:44 PM Lee Jones <lee.jones@linaro.org> wrote:
    >
    > Fixes the following W=1 kernel build warning(s):
    >
    > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:453: warning: Function parameter or member 'ih' not described in 'navi10_ih_get_wptr'
    > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:512: warning: Function parameter or member 'ih' not described in 'navi10_ih_decode_iv'
    > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:512: warning: Function parameter or member 'entry' not described in 'navi10_ih_decode_iv'
    > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:552: warning: Function parameter or member 'ih' not described in 'navi10_ih_irq_rearm'
    > drivers/gpu/drm/amd/amdgpu/navi10_ih.c:585: warning: Function parameter or member 'ih' not described in 'navi10_ih_set_rptr'
    >
    > Cc: Alex Deucher <alexander.deucher@amd.com>
    > Cc: "Christian König" <christian.koenig@amd.com>
    > Cc: David Airlie <airlied@linux.ie>
    > Cc: Daniel Vetter <daniel@ffwll.ch>
    > Cc: Alex Sierra <alex.sierra@amd.com>
    > Cc: amd-gfx@lists.freedesktop.org
    > Cc: dri-devel@lists.freedesktop.org
    > Signed-off-by: Lee Jones <lee.jones@linaro.org>

    Applied. Thanks!

    Alex

    > ---
    > drivers/gpu/drm/amd/amdgpu/navi10_ih.c | 5 +++++
    > 1 file changed, 5 insertions(+)
    >
    > diff --git a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c
    > index 837769fcb35b7..3338052b080b6 100644
    > --- a/drivers/gpu/drm/amd/amdgpu/navi10_ih.c
    > +++ b/drivers/gpu/drm/amd/amdgpu/navi10_ih.c
    > @@ -442,6 +442,7 @@ static void navi10_ih_irq_disable(struct amdgpu_device *adev)
    > * navi10_ih_get_wptr - get the IH ring buffer wptr
    > *
    > * @adev: amdgpu_device pointer
    > + * @ih: IH ring buffer to fetch wptr
    > *
    > * Get the IH ring buffer wptr from either the register
    > * or the writeback memory buffer (NAVI10). Also check for
    > @@ -502,6 +503,8 @@ static u32 navi10_ih_get_wptr(struct amdgpu_device *adev,
    > * navi10_ih_decode_iv - decode an interrupt vector
    > *
    > * @adev: amdgpu_device pointer
    > + * @ih: IH ring buffer to decode
    > + * @entry: IV entry to place decoded information into
    > *
    > * Decodes the interrupt vector at the current rptr
    > * position and also advance the position.
    > @@ -545,6 +548,7 @@ static void navi10_ih_decode_iv(struct amdgpu_device *adev,
    > * navi10_ih_irq_rearm - rearm IRQ if lost
    > *
    > * @adev: amdgpu_device pointer
    > + * @ih: IH ring to match
    > *
    > */
    > static void navi10_ih_irq_rearm(struct amdgpu_device *adev,
    > @@ -578,6 +582,7 @@ static void navi10_ih_irq_rearm(struct amdgpu_device *adev,
    > *
    > * @adev: amdgpu_device pointer
    > *
    > + * @ih: IH ring buffer to set rptr
    > * Set the IH ring buffer rptr.
    > */
    > static void navi10_ih_set_rptr(struct amdgpu_device *adev,
    > --
    > 2.25.1
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2020-11-30 23:12    [W:2.891 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site