lkml.org 
[lkml]   [2020]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] __div64_32(): straighten up inline asm constraints
On Mon, 30 Nov 2020, Nick Desaulniers wrote:

> On Mon, Nov 30, 2020 at 11:05 AM Nicolas Pitre <nico@fluxnic.net> wrote:
>
> > + __rem = __n >> 32;
> > *n = __res;
> > return __rem;
>
> The above 3 statement could be:
>
> ```
> *n = __res;
> return __n >> 32;
> ```

They could. However the compiler doesn't care, and the extra line makes
it more obvious that the reminder is the high part of __n. So,
semantically the extra line has value.

Thanks for the review.


Nicolas

\
 
 \ /
  Last update: 2020-11-30 21:29    [W:0.048 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site