[lkml]   [2020]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RFC PATCH 12/13] fs/userfaultfd: kmem-cache for wait-queue objects
> On Nov 28, 2020, at 4:45 PM, Nadav Amit <> wrote:
> From: Nadav Amit <>
> Allocating work-queue objects on the stack has usually negative
> performance side-effects. First, it is hard to ensure alignment to
> cache-lines without increasing the stack size. Second, it might cause
> false sharing. Third, it is more likely to encounter TLB misses as
> objects are more likely reside on different pages.
> Allocate userfaultfd wait-queue objects on the heap using kmem-cache for
> better performance.

Err… The wait-queue objects are still on the stack in some cases that I
missed. Will fix.
 \ /
  Last update: 2020-11-30 20:55    [W:0.280 / U:0.624 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site