Messages in this thread |  | | Subject | Re: [RFC PATCH 12/13] fs/userfaultfd: kmem-cache for wait-queue objects | From | Nadav Amit <> | Date | Mon, 30 Nov 2020 11:51:22 -0800 |
| |
> On Nov 28, 2020, at 4:45 PM, Nadav Amit <nadav.amit@gmail.com> wrote: > > From: Nadav Amit <namit@vmware.com> > > Allocating work-queue objects on the stack has usually negative > performance side-effects. First, it is hard to ensure alignment to > cache-lines without increasing the stack size. Second, it might cause > false sharing. Third, it is more likely to encounter TLB misses as > objects are more likely reside on different pages. > > Allocate userfaultfd wait-queue objects on the heap using kmem-cache for > better performance.
Err… The wait-queue objects are still on the stack in some cases that I missed. Will fix.
|  |