Messages in this thread | | | Date | Mon, 30 Nov 2020 21:21:16 +0200 | From | Andy Shevchenko <> | Subject | Re: [PATCH 02/18] property: Add support for calling fwnode_graph_get_endpoint_by_id() for fwnode->secondary |
| |
On Mon, Nov 30, 2020 at 08:41:41PM +0200, Laurent Pinchart wrote: > On Mon, Nov 30, 2020 at 07:53:19PM +0200, Andy Shevchenko wrote: > > On Mon, Nov 30, 2020 at 07:28:57PM +0200, Laurent Pinchart wrote: > > > On Mon, Nov 30, 2020 at 07:29:00PM +0200, Andy Shevchenko wrote:
...
> > > We could also move the !fwnode check to the beginning of the function. > > > > It's already there (1). What did I miss? > > It is, but as we need an explicitly check at the end, it feels cleaner > to move it to the beginning. No big deal though.
I prefer to stick with a pattern I mentioned because we may easily to find and unify these ones somehow.
> > 1) via fwnode_graph_get_next_endpoint() -> fwnode_call_ptr_op()
-- With Best Regards, Andy Shevchenko
| |