Messages in this thread | | | From | KP Singh <> | Date | Tue, 3 Nov 2020 19:59:08 +0100 | Subject | Re: [PATCH bpf-next v2 7/8] bpf: Add tests for task_local_storage |
| |
On Tue, Nov 3, 2020 at 7:47 PM Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote: > > On Tue, Nov 03, 2020 at 04:31:31PM +0100, KP Singh wrote: > > + > > +struct storage { > > + void *inode; > > + unsigned int value; > > + /* Lock ensures that spin locked versions of local stoage operations > > + * also work, most operations in this tests are still single threaded > > + */ > > + struct bpf_spin_lock lock; > > +}; > > I think it's a good idea to test spin_lock in local_storage, > but it seems the test is not doing it fully. > It's only adding it to the storage, but the program is not accessing it.
I added it here just to check if the offset calculations (map->spin_lock_off) are correctly happening for these new maps.
As mentioned in the updates, I do intend to generalize tools/testing/selftests/bpf/map_tests/sk_storage_map.c which already has the threading logic to exercise bpf_spin_lock in storage maps.
Hope this is an okay plan?
| |