lkml.org 
[lkml]   [2020]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xfs: Drop useless comments
On Mon, Nov 02, 2020 at 08:03:16AM +0800, Fengfei Xi wrote:
> The names of functions xfs_buf_get_maps and _xfs_buf_free_pages

xfs_buf_get_maps? I don't see any changes for that function...?

--D

> can fully express their roles. So their comments are redundant.
> We could drop them entirely.
>
> Signed-off-by: Fengfei Xi <fengfei_xi@126.com>
> ---
> fs/xfs/xfs_buf.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c
> index 4e4cf91..2aeed30 100644
> --- a/fs/xfs/xfs_buf.c
> +++ b/fs/xfs/xfs_buf.c
> @@ -197,9 +197,6 @@
> return 0;
> }
>
> -/*
> - * Frees b_pages if it was allocated.
> - */
> static void
> xfs_buf_free_maps(
> struct xfs_buf *bp)
> @@ -297,9 +294,6 @@
> return 0;
> }
>
> -/*
> - * Frees b_pages if it was allocated.
> - */
> STATIC void
> _xfs_buf_free_pages(
> xfs_buf_t *bp)
> --
> 1.9.1
>

\
 
 \ /
  Last update: 2020-11-03 19:51    [W:0.095 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site