Messages in this thread | | | From | George Cherian <> | Subject | Re: [net-next PATCH 2/3] octeontx2-af: Add devlink health reporters for NPA | Date | Tue, 3 Nov 2020 17:57:15 +0000 |
| |
Hi Willem,
> -----Original Message----- > From: Willem de Bruijn <willemdebruijn.kernel@gmail.com> > Sent: Tuesday, November 3, 2020 7:21 PM > To: George Cherian <gcherian@marvell.com> > Cc: Network Development <netdev@vger.kernel.org>; linux-kernel <linux- > kernel@vger.kernel.org>; Jakub Kicinski <kuba@kernel.org>; David Miller > <davem@davemloft.net>; Sunil Kovvuri Goutham > <sgoutham@marvell.com>; Linu Cherian <lcherian@marvell.com>; > Geethasowjanya Akula <gakula@marvell.com>; masahiroy@kernel.org > Subject: [EXT] Re: [net-next PATCH 2/3] octeontx2-af: Add devlink health > reporters for NPA > > > > > static int rvu_devlink_info_get(struct devlink *devlink, struct > > > devlink_info_req *req, > > > > struct netlink_ext_ack *extack) { @@ > > > > -53,7 +483,8 @@ int rvu_register_dl(struct rvu *rvu) > > > > rvu_dl->dl = dl; > > > > rvu_dl->rvu = rvu; > > > > rvu->rvu_dl = rvu_dl; > > > > - return 0; > > > > + > > > > + return rvu_health_reporters_create(rvu); > > > > > > when would this be called with rvu->rvu_dl == NULL? > > > > During initialization. > > This is the only caller, and it is only reached if rvu_dl is non-zero.
Yes!!! I got it, will address it in v2.
Regards -George
| |