Messages in this thread | | | Subject | Re: [PATCH v1] PCI: brcmstb: variable is missing proper initialization | From | Nicolas Saenz Julienne <> | Date | Tue, 03 Nov 2020 18:32:54 +0100 |
| |
On Mon, 2020-11-02 at 13:07 -0800, Florian Fainelli wrote: > > On 11/2/2020 12:57 PM, Jim Quinlan wrote: > > The variable 'tmp' is used multiple times in the brcm_pcie_setup() > > function. One such usage did not initialize 'tmp' to the current value of > > the target register. By luck the mistake does not currently affect > > behavior; regardless 'tmp' is now initialized properly. > > > > Fixes: c0452137034b ("PCI: brcmstb: Add Broadcom STB PCIe host controller driver") > > Suggested-by: Rafał Miłecki <zajec5@gmail.com> > > Signed-off-by: Jim Quinlan <james.quinlan@broadcom.com>
Acked-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
[unhandled content-type:application/pgp-signature] | |