Messages in this thread | | | Subject | Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY | From | Dan Murphy <> | Date | Tue, 3 Nov 2020 11:09:44 -0600 |
| |
Hello
On 10/30/20 6:03 PM, Jakub Kicinski wrote: > On Fri, 30 Oct 2020 12:29:50 -0500 Dan Murphy wrote: >> The DP83TD510E is an ultra-low power Ethernet physical layer transceiver >> that supports 10M single pair cable. >> >> The device supports both 2.4-V p2p and 1-V p2p output voltage as defined >> by IEEE 802.3cg 10Base-T1L specfications. These modes can be forced via >> the device tree or the device is defaulted to auto negotiation to >> determine the proper p2p voltage. >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> > drivers/net/phy/dp83td510.c:70:11: warning: symbol 'dp83td510_feature_array' was not declared. Should it be static? I did not see this warning. Did you use W=1? > > > Also this: > > WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP > #429: FILE: drivers/net/phy/dp83td510.c:371: > + return -ENOTSUPP; > > WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP > #524: FILE: drivers/net/phy/dp83td510.c:466: > + return -ENOTSUPP; Same with these warnings how where they reproduced? > > ERROR: space required before the open parenthesis '(' > #580: FILE: drivers/net/phy/dp83td510.c:522: > + if(phydev->autoneg) { > > ERROR: space required before the open parenthesis '(' > #588: FILE: drivers/net/phy/dp83td510.c:530: > + if(phydev->autoneg) { > > > And please try to wrap the code on 80 chars on the non trivial lines:
What is the LoC limit for networking just for my clarification and I will align with that.
I know some maintainers like to keep the 80 LoC and some allow a longer line.
Dan
| |