lkml.org 
[lkml]   [2020]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 18/25] soc: qcom: wcnss_ctrl: Demote non-conformant struct header and fix function headers
    Date
    Fixes the following W=1 kernel build warning(s):

    drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'major' not described in 'wcnss_version_resp'
    drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'minor' not described in 'wcnss_version_resp'
    drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'version' not described in 'wcnss_version_resp'
    drivers/soc/qcom/wcnss_ctrl.c:81: warning: Function parameter or member 'revision' not described in 'wcnss_version_resp'
    drivers/soc/qcom/wcnss_ctrl.c:122: warning: Function parameter or member 'rpdev' not described in 'wcnss_ctrl_smd_callback'
    drivers/soc/qcom/wcnss_ctrl.c:122: warning: Function parameter or member 'priv' not described in 'wcnss_ctrl_smd_callback'
    drivers/soc/qcom/wcnss_ctrl.c:122: warning: Function parameter or member 'addr' not described in 'wcnss_ctrl_smd_callback'
    drivers/soc/qcom/wcnss_ctrl.c:122: warning: Excess function parameter 'channel' description in 'wcnss_ctrl_smd_callback'
    drivers/soc/qcom/wcnss_ctrl.c:272: warning: Function parameter or member 'priv' not described in 'qcom_wcnss_open_channel'

    Cc: Andy Gross <agross@kernel.org>
    Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
    Cc: linux-arm-msm@vger.kernel.org
    Signed-off-by: Lee Jones <lee.jones@linaro.org>
    ---
    drivers/soc/qcom/wcnss_ctrl.c | 8 +++++---
    1 file changed, 5 insertions(+), 3 deletions(-)

    diff --git a/drivers/soc/qcom/wcnss_ctrl.c b/drivers/soc/qcom/wcnss_ctrl.c
    index e5c68051fb175..32bed249f90e5 100644
    --- a/drivers/soc/qcom/wcnss_ctrl.c
    +++ b/drivers/soc/qcom/wcnss_ctrl.c
    @@ -68,9 +68,8 @@ struct wcnss_msg_hdr {
    u32 len;
    } __packed;

    -/**
    +/*
    * struct wcnss_version_resp - version request response
    - * @hdr: common packet wcnss_msg_hdr header
    */
    struct wcnss_version_resp {
    struct wcnss_msg_hdr hdr;
    @@ -108,9 +107,11 @@ struct wcnss_download_nv_resp {

    /**
    * wcnss_ctrl_smd_callback() - handler from SMD responses
    - * @channel: smd channel handle
    + * @rpdev: remote processor message device pointer
    * @data: pointer to the incoming data packet
    * @count: size of the incoming data packet
    + * @priv: unused
    + * @addr: unused
    *
    * Handles any incoming packets from the remote WCNSS_CTRL service.
    */
    @@ -267,6 +268,7 @@ static int wcnss_download_nv(struct wcnss_ctrl *wcnss, bool *expect_cbc)
    * @wcnss: wcnss handle, retrieved from drvdata
    * @name: SMD channel name
    * @cb: callback to handle incoming data on the channel
    + * @priv: private data for use in the call-back
    */
    struct rpmsg_endpoint *qcom_wcnss_open_channel(void *wcnss, const char *name, rpmsg_rx_cb_t cb, void *priv)
    {
    --
    2.25.1
    \
     
     \ /
      Last update: 2020-11-03 16:31    [W:4.143 / U:0.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site