lkml.org 
[lkml]   [2020]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v5] mtd: spinand: micron: add support for MT29F2G01AAAED
On Tue,  3 Nov 2020 22:59:01 +0800
Thirumalesha Narasimhappa <nthirumalesha7@gmail.com> wrote:

> The MT29F2G01AAAED is a single die, 2Gb Micron SPI NAND Flash with 4-bit
> ECC
>
> Signed-off-by: Thirumalesha Narasimhappa <nthirumalesha7@gmail.com>
> ---
>
> v5: As per the review comments, the changes were reverted to the v2,
> except the MT29F2G01AAAED device related (including the review comments)

I don't think that's what Miquel suggested, especially not for the
{write,update,write}_cache_variants helpers.

>
> v4: Split patch into two parts,
> 1. Generalise the oob structure name & function names as show in v3
> 2. Add support for MT29F2G01AAAED device
> a. Add oob section check in micron_ooblayout_free function
> b. Rename mt29f2g01aaaed_* to generic name micron_4_*
>
> v3: As per the review comments,
> 1. Renamed read_cache_variants as quadio_read_cache_variants,
> write_cache_variants as
> x4_write_cache_variants/x1_write_cache_variants,
> update_cache_variants as
> x4_update_cache_variants/x1_update_cache_variants,
> read_cache_variants as x4_read_cache_variants
> 2. Renamed micron_8_ooblayout as micron_grouped_ooblayout &
> mt29f2g01aaaed_ooblayout as
> micron_interleaved_ooblayout
> 3. Generalized page size based oob section check in
> mt29f2g01aaaed_ooblayout_ecc function
> and separate case check for two bytes BBM reserved in
> mt29f2g01aaaed_ooblayout_free function
> 4. Removed mt29f2g01aaaed_ecc_get_status function &
> MICRON_STATUS_ECC_1TO4_BITFLIPS
>
> v2: Removed SPINAND_SELECT_TARGET as per the comments & fixed typo
> errors
>
> v1: Add support for Micron SPI Nand device MT29F2G01AAAED
>
> drivers/mtd/nand/spi/micron.c | 64 +++++++++++++++++++++++++++++++++++
> 1 file changed, 64 insertions(+)
>
> diff --git a/drivers/mtd/nand/spi/micron.c b/drivers/mtd/nand/spi/micron.c
> index 5d370cfcdaaa..0b1e48d5c9d4 100644
> --- a/drivers/mtd/nand/spi/micron.c
> +++ b/drivers/mtd/nand/spi/micron.c
> @@ -44,6 +44,19 @@ static SPINAND_OP_VARIANTS(update_cache_variants,
> SPINAND_PROG_LOAD_X4(false, 0, NULL, 0),
> SPINAND_PROG_LOAD(false, 0, NULL, 0));
>
> +/* Micron MT29F2G01AAAED Device */
> +static SPINAND_OP_VARIANTS(micron_4_read_cache_variants,
> + SPINAND_PAGE_READ_FROM_CACHE_X4_OP(0, 1, NULL, 0),
> + SPINAND_PAGE_READ_FROM_CACHE_X2_OP(0, 1, NULL, 0),
> + SPINAND_PAGE_READ_FROM_CACHE_OP(true, 0, 1, NULL, 0),
> + SPINAND_PAGE_READ_FROM_CACHE_OP(false, 0, 1, NULL, 0));
> +
> +static SPINAND_OP_VARIANTS(micron_4_write_cache_variants,
> + SPINAND_PROG_LOAD(true, 0, NULL, 0));
> +
> +static SPINAND_OP_VARIANTS(micron_4_update_cache_variants,
> + SPINAND_PROG_LOAD(false, 0, NULL, 0));
> +
> static int micron_8_ooblayout_ecc(struct mtd_info *mtd, int section,
> struct mtd_oob_region *region)
> {
> @@ -74,6 +87,47 @@ static const struct mtd_ooblayout_ops micron_8_ooblayout = {
> .free = micron_8_ooblayout_free,
> };
>
> +static int micron_4_ooblayout_ecc(struct mtd_info *mtd, int section,
> + struct mtd_oob_region *region)
> +{
> + struct spinand_device *spinand = mtd_to_spinand(mtd);
> +
> + if (section >= spinand->base.memorg.pagesize /
> + mtd->ecc_step_size)
> + return -ERANGE;
> +
> + region->offset = (section * 16) + 8;
> + region->length = 8;
> +
> + return 0;
> +}
> +
> +static int micron_4_ooblayout_free(struct mtd_info *mtd, int section,
> + struct mtd_oob_region *region)
> +{
> + struct spinand_device *spinand = mtd_to_spinand(mtd);
> +
> + if (section >= spinand->base.memorg.pagesize /
> + mtd->ecc_step_size)
> + return -ERANGE;
> +
> + if (section) {
> + region->offset = 16 * section;
> + region->length = 8;
> + } else {
> + /* section 0 has two bytes reserved for the BBM */
> + region->offset = 2;
> + region->length = 6;
> + }
> +
> + return 0;
> +}
> +
> +static const struct mtd_ooblayout_ops micron_4_ooblayout = {
> + .ecc = micron_4_ooblayout_ecc,
> + .free = micron_4_ooblayout_free,
> +};
> +
> static int micron_select_target(struct spinand_device *spinand,
> unsigned int target)
> {
> @@ -217,6 +271,16 @@ static const struct spinand_info micron_spinand_table[] = {
> SPINAND_ECCINFO(&micron_8_ooblayout,
> micron_8_ecc_get_status),
> SPINAND_SELECT_TARGET(micron_select_target)),
> + /* M69A 2Gb 3.3V */
> + SPINAND_INFO("MT29F2G01AAAED",
> + SPINAND_ID(SPINAND_READID_METHOD_OPCODE_DUMMY, 0x9F),
> + NAND_MEMORG(1, 2048, 64, 64, 2048, 80, 2, 1, 1),
> + NAND_ECCREQ(4, 512),
> + SPINAND_INFO_OP_VARIANTS(&micron_4_read_cache_variants,
> + &micron_4_write_cache_variants,
> + &micron_4_update_cache_variants),
> + 0,
> + SPINAND_ECCINFO(&micron_4_ooblayout, NULL)),
> };
>
> static int micron_spinand_init(struct spinand_device *spinand)

\
 
 \ /
  Last update: 2020-11-03 16:05    [W:0.049 / U:0.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site