lkml.org 
[lkml]   [2020]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v2] mtd:ubi: Remove useless code in bytes_str_to_int
    Date
    On Tue, Nov 3, 2020 at 1:00 PM Chengsong Ke <kechengsong@huawei.com> wrote:
    >
    > From: Chengsong Ke <kechengsong@huawei.com>
    >
    > As a local variable, "endp" is neither refered nor returned after this
    > line "endp += 2", it looks like a useless code, suggest to remove it.
    >
    > Signed-off-by: Chengsong Ke <kechengsong@huawei.com>
    > ---
    > drivers/mtd/ubi/build.c | 2 --
    > 1 file changed, 2 deletions(-)
    >
    > diff --git a/drivers/mtd/ubi/build.c b/drivers/mtd/ubi/build.c index
    > e85b04e9716b..46a6dd75e533 100644
    > --- a/drivers/mtd/ubi/build.c
    > +++ b/drivers/mtd/ubi/build.c
    > @@ -1351,8 +1351,6 @@ static int bytes_str_to_int(const char *str)
    > fallthrough;
    > case 'K':
    > result *= 1024;
    > - if (endp[1] == 'i' && endp[2] == 'B')
    > - endp += 2;

    > Makes sense. But why did you send a v2?

    > --
    > Thanks,
    > //richard

    I just send the v1 with the wrong module name 'ubifs'.
    [PATCH] ubifs: Remove useless code in bytes_str_to_int
    :-)
    Thanks,
    //Chengsong Ke

    \
     
     \ /
      Last update: 2020-11-03 14:17    [W:2.197 / U:1.676 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site