Messages in this thread | | | Subject | Re: [PATCH 2/2] pinctrl: qcom: Add sc7280 pinctrl driver | From | Rajendra Nayak <> | Date | Tue, 3 Nov 2020 16:09:34 +0530 |
| |
On 10/29/2020 7:50 PM, Bjorn Andersson wrote: > On Fri 16 Oct 01:58 CDT 2020, Rajendra Nayak wrote: >> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280.c b/drivers/pinctrl/qcom/pinctrl-sc7280.c > [..] >> +static const struct msm_function sc7280_functions[] = { > [..] >> + FUNCTION(phase_flag0), >> + FUNCTION(phase_flag1), >> + FUNCTION(phase_flag10), >> + FUNCTION(phase_flag11), >> + FUNCTION(phase_flag12), >> + FUNCTION(phase_flag13), >> + FUNCTION(phase_flag14), >> + FUNCTION(phase_flag15), >> + FUNCTION(phase_flag16), >> + FUNCTION(phase_flag17), >> + FUNCTION(phase_flag18), >> + FUNCTION(phase_flag19), >> + FUNCTION(phase_flag2), >> + FUNCTION(phase_flag20), >> + FUNCTION(phase_flag21), >> + FUNCTION(phase_flag22), >> + FUNCTION(phase_flag23), >> + FUNCTION(phase_flag24), >> + FUNCTION(phase_flag25), >> + FUNCTION(phase_flag26), >> + FUNCTION(phase_flag27), >> + FUNCTION(phase_flag28), >> + FUNCTION(phase_flag29), >> + FUNCTION(phase_flag3), >> + FUNCTION(phase_flag30), >> + FUNCTION(phase_flag31), >> + FUNCTION(phase_flag4), >> + FUNCTION(phase_flag5), >> + FUNCTION(phase_flag6), >> + FUNCTION(phase_flag7), >> + FUNCTION(phase_flag8), >> + FUNCTION(phase_flag9), > > I prefer when we squash these into a single function. > >> + FUNCTION(pll_bist), >> + FUNCTION(pll_bypassnl), >> + FUNCTION(pll_clk), >> + FUNCTION(pll_reset), >> + FUNCTION(pri_mi2s), >> + FUNCTION(prng_rosc), >> + FUNCTION(qdss_cti), >> + FUNCTION(qdss_gpio), >> + FUNCTION(qdss_gpio0), >> + FUNCTION(qdss_gpio1), >> + FUNCTION(qdss_gpio10), >> + FUNCTION(qdss_gpio11), >> + FUNCTION(qdss_gpio12), >> + FUNCTION(qdss_gpio13), >> + FUNCTION(qdss_gpio14), >> + FUNCTION(qdss_gpio15), >> + FUNCTION(qdss_gpio2), >> + FUNCTION(qdss_gpio3), >> + FUNCTION(qdss_gpio4), >> + FUNCTION(qdss_gpio5), >> + FUNCTION(qdss_gpio6), >> + FUNCTION(qdss_gpio7), >> + FUNCTION(qdss_gpio8), >> + FUNCTION(qdss_gpio9), > > Ditto. > >> + FUNCTION(qlink0_enable), >> + FUNCTION(qlink0_request), >> + FUNCTION(qlink0_wmss), >> + FUNCTION(qlink1_enable), >> + FUNCTION(qlink1_request), >> + FUNCTION(qlink1_wmss), >> + FUNCTION(qspi_clk), >> + FUNCTION(qspi_cs), >> + FUNCTION(qspi_data), >> + FUNCTION(qup00), >> + FUNCTION(qup01), >> + FUNCTION(qup02), >> + FUNCTION(qup03), >> + FUNCTION(qup04), >> + FUNCTION(qup05), >> + FUNCTION(qup06), >> + FUNCTION(qup07), >> + FUNCTION(qup10), >> + FUNCTION(qup11), >> + FUNCTION(qup12), >> + FUNCTION(qup13), >> + FUNCTION(qup14), >> + FUNCTION(qup15), >> + FUNCTION(qup16), >> + FUNCTION(qup17), >> + FUNCTION(sdc40), >> + FUNCTION(sdc41), >> + FUNCTION(sdc42), >> + FUNCTION(sdc43), >> + FUNCTION(sdc4_clk), >> + FUNCTION(sdc4_cmd), >> + FUNCTION(sd_write), >> + FUNCTION(sec_mi2s), >> + FUNCTION(tb_trig), >> + FUNCTION(tgu_ch0), >> + FUNCTION(tgu_ch1), >> + FUNCTION(tsense_pwm1), >> + FUNCTION(tsense_pwm2), >> + FUNCTION(uim0_clk), >> + FUNCTION(uim0_data), >> + FUNCTION(uim0_present), >> + FUNCTION(uim0_reset), >> + FUNCTION(uim1_clk), >> + FUNCTION(uim1_data), >> + FUNCTION(uim1_present), >> + FUNCTION(uim1_reset), >> + FUNCTION(usb2phy_ac), >> + FUNCTION(usb_phy), >> + FUNCTION(vfr_0), >> + FUNCTION(vfr_1), >> + FUNCTION(vsense_trigger), >> +}; >> + >> +/* Every pin is maintained as a single group, and missing or non-existing pin >> + * would be maintained as dummy group to synchronize pin group index with >> + * pin descriptor registered with pinctrl core. >> + * Clients would not be able to request these dummy pin groups. >> + */ >> +static const struct msm_pingroup sc7280_groups[] = { > [..] >> + [174] = PINGROUP(174, qdss_gpio15, _, _, _, _, _, _, _, _), >> + [175] = SDC_QDSD_PINGROUP(sdc1_rclk, 0x1b3000, 15, 0), >> + [176] = SDC_QDSD_PINGROUP(sdc1_clk, 0x1b3000, 13, 6), >> + [177] = SDC_QDSD_PINGROUP(sdc1_cmd, 0x1b3000, 11, 3), >> + [178] = SDC_QDSD_PINGROUP(sdc1_data, 0x1b3000, 9, 0), >> + [179] = SDC_QDSD_PINGROUP(sdc2_clk, 0x1b4000, 14, 6), >> + [180] = SDC_QDSD_PINGROUP(sdc2_cmd, 0x1b4000, 11, 3), >> + [181] = SDC_QDSD_PINGROUP(sdc2_data, 0x1b4000, 9, 0), >> + [182] = UFS_RESET(ufs_reset, 0x1be000), > > Rather than fiddling ufs reset using pinconf we expose it as a gp(i)o > pin upstream. So please move this to be the 175th item in the list and > bump ngpios to 176 below. > >> +}; >> + >> +static const struct msm_pinctrl_soc_data sc7280_pinctrl = { >> + .pins = sc7280_pins, >> + .npins = ARRAY_SIZE(sc7280_pins), >> + .functions = sc7280_functions, >> + .nfunctions = ARRAY_SIZE(sc7280_functions), >> + .groups = sc7280_groups, >> + .ngroups = ARRAY_SIZE(sc7280_groups), >> + .ngpios = 175, >> +}; >> + > > Apart from that it looks good.
thanks Bjorn, I'll fix-up and re-post.
-- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
| |