lkml.org 
[lkml]   [2020]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH -next] dpaa_eth: use false and true for bool variables
Date
> -----Original Message-----
> From: Zou Wei <zou_wei@huawei.com>
> Sent: 03 November 2020 14:05
> To: Madalin Bucur <madalin.bucur@nxp.com>; davem@davemloft.net;
> kuba@kernel.org
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zou Wei
> <zou_wei@huawei.com>
> Subject: [PATCH -next] dpaa_eth: use false and true for bool variables
>
> Fix coccicheck warnings:
>
> ./dpaa_eth.c:2549:2-22: WARNING: Assignment of 0/1 to bool variable
> ./dpaa_eth.c:2562:2-22: WARNING: Assignment of 0/1 to bool variable
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index d9c2859..31407c1 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -2546,7 +2546,7 @@ static void dpaa_eth_napi_enable(struct dpaa_priv
> *priv)
> for_each_online_cpu(i) {
> percpu_priv = per_cpu_ptr(priv->percpu_priv, i);
>
> - percpu_priv->np.down = 0;
> + percpu_priv->np.down = false;
> napi_enable(&percpu_priv->np.napi);
> }
> }
> @@ -2559,7 +2559,7 @@ static void dpaa_eth_napi_disable(struct dpaa_priv
> *priv)
> for_each_online_cpu(i) {
> percpu_priv = per_cpu_ptr(priv->percpu_priv, i);
>
> - percpu_priv->np.down = 1;
> + percpu_priv->np.down = true;
> napi_disable(&percpu_priv->np.napi);
> }
> }
> --
> 2.6.2

Acked-by: Madalin Bucur <madalin.bucur@oss.nxp.com>

\
 
 \ /
  Last update: 2020-11-03 13:14    [W:0.062 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site