Messages in this thread | | | Subject | Re: [PATCH 0/3] mtd: Make sure UBIFS does not do multi-pass page programming on flashes that don't support it | From | Vignesh Raghavendra <> | Date | Tue, 3 Nov 2020 17:05:01 +0530 |
| |
On 11/1/20 3:14 AM, Richard Weinberger wrote: > On Tue, Oct 27, 2020 at 12:24 PM Pratyush Yadav <p.yadav@ti.com> wrote: >>> [0] https://lore.kernel.org/linux-mtd/20201005153138.6437-1-p.yadav@ti.com/ >> >> Ping. Any comments on the series? > > From the UBIFS point of view I'd like to avoid as many device specific > settings as possible. > We check already for NOR flash, checking for NOR *and* SPI_NOR_NO_MULTI_PASS_PP > feels a bit clumsy. > > Tudor, what do you think about SPI_NOR_NO_MULTI_PASS_PP? > This kind of NOR seems to be a little NAND'ish. Maybe we can hide this detail > in the mtd framework? >
Agree with Richard. I don't see need for SPI_NOR_NO_MULTI_PASS_PP. From MTD point of view setting mtd->writesize to be equal to pagesize should be enough. Its upto clients of MTD devices to ensure there is no multi pass programming within a "writesize" block.
If this is not clear in the current documentation of struct mtd, then that can be updated.
Regards Vignesh
| |