Messages in this thread | | | From | David Laight <> | Subject | RE: [PATCH v3] qnx4: qnx4_block_map error handling | Date | Tue, 3 Nov 2020 10:54:02 +0000 |
| |
From: Tong Zhang > Sent: 02 November 2020 23:14 > > qnx4_block_map() may return -EIO on funny qnx4 fs image, in this case do > not interpret -EIO as a correct block number
That commit message is now wrong.
Also 'blknum' is only 'unsigned long' so ~0ull is wrong. It can be worth injecting an error and checking the error propagation works.
What is the actual maximum file size? Is there actually an 'out of range' blknum value that can be used to signify an error without changing the return value to 'long long'.
David
- Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)
| |