Messages in this thread | | | Date | Tue, 3 Nov 2020 08:35:33 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 1/4] kexec: simplify compat_sys_kexec_load |
| |
> + for (i=0; i < nr_segments; i++) {
Missing spaces around the "=".
> +SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments, > + struct kexec_segment __user *, segments, unsigned long, flags) > +{ > + return kernel_kexec_load(entry, nr_segments, segments, flags); > +} > + > #ifdef CONFIG_COMPAT > COMPAT_SYSCALL_DEFINE4(kexec_load, compat_ulong_t, entry, > compat_ulong_t, nr_segments, > struct compat_kexec_segment __user *, segments, > compat_ulong_t, flags) > { > + return kernel_kexec_load(entry, nr_segments, > + (struct kexec_segment __user *)segments, > + flags); > }
I don't think we need sys_compat_kexec_load at all now, all the syscall tables can simply switch to sys_kexec_load for the compat case as well now.
| |