Messages in this thread | | | Subject | Re: [PATCH v2] spi: bcm63xx-hsspi: fix missing clk_disable_unprepare() on error in bcm63xx_hsspi_resume | From | Qinglang Miao <> | Date | Tue, 3 Nov 2020 16:18:52 +0800 |
| |
在 2020/11/3 15:49, Qinglang Miao 写道: > Fix the missing clk_disable_unprepare() before return > from bcm63xx_hsspi_resume in the error handling case when > fails to prepare and enable bs->pll_clk. > > Fixes: 0fd85869c2a9 ("spi/bcm63xx-hsspi: keep pll clk enabled") > Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com> > --- > drivers/spi/spi-bcm63xx-hsspi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-bcm63xx-hsspi.c b/drivers/spi/spi-bcm63xx-hsspi.c > index 9909b18f3..1f08d7553 100644 > --- a/drivers/spi/spi-bcm63xx-hsspi.c > +++ b/drivers/spi/spi-bcm63xx-hsspi.c > @@ -494,8 +494,10 @@ static int bcm63xx_hsspi_resume(struct device *dev) > > if (bs->pll_clk) { > ret = clk_prepare_enable(bs->pll_clk); > - if (ret) > + if (ret) { > + clk_disable_unprepare(bs->clk); > return ret; > + } > } > > spi_master_resume(master); > Hi Mark and Florian,
I made a careless mistake for adding v2 as subject-prefix, this patch is the base version actually.
Sorry about that.
Thanks.
| |