Messages in this thread | | | Subject | Re: [PATCH v2 17/17] vdpa: split vdpasim to core and net modules | From | Jason Wang <> | Date | Mon, 30 Nov 2020 11:31:43 +0800 |
| |
On 2020/11/26 下午10:49, Stefano Garzarella wrote: > From: Max Gurtovoy<mgurtovoy@nvidia.com> > > Introduce new vdpa_sim_net and vdpa_sim (core) drivers. This is a > preparation for adding a vdpa simulator module for block devices. > > Signed-off-by: Max Gurtovoy<mgurtovoy@nvidia.com> > [sgarzare: various cleanups/fixes] > Signed-off-by: Stefano Garzarella<sgarzare@redhat.com> > --- > v2: > - Fixed "warning: variable 'dev' is used uninitialized" reported by > 'kernel test robot' and Dan Carpenter > - rebased on top of other changes (dev_attr, get_config(), notify(), etc.) > - left batch_mapping module parameter in the core [Jason] > > v1: > - Removed unused headers > - Removed empty module_init() module_exit() > - Moved vdpasim_is_little_endian() in vdpa_sim.h > - Moved vdpasim16_to_cpu/cpu_to_vdpasim16() in vdpa_sim.h > - Added vdpasim*_to_cpu/cpu_to_vdpasim*() also for 32 and 64 > - Replaced 'select VDPA_SIM' with 'depends on VDPA_SIM' since selected > option can not depend on other [Jason] > --- > drivers/vdpa/vdpa_sim/vdpa_sim.h | 103 +++++++++++++ > drivers/vdpa/vdpa_sim/vdpa_sim.c | 222 +-------------------------- > drivers/vdpa/vdpa_sim/vdpa_sim_net.c | 171 +++++++++++++++++++++ > drivers/vdpa/Kconfig | 13 +- > drivers/vdpa/vdpa_sim/Makefile | 1 + > 5 files changed, 290 insertions(+), 220 deletions(-) > create mode 100644 drivers/vdpa/vdpa_sim/vdpa_sim.h > create mode 100644 drivers/vdpa/vdpa_sim/vdpa_sim_net.c
Looks good, consider there are some still some questions left. I will probably ack for the next version.
Thanks
| |